Browse Source

PMD & FindBugs

Ranides Atterwim 10 năm trước cách đây
mục cha
commit
2c24b91941

+ 4 - 1
assira/src/main/java/net/ranides/assira/text/StrBuilder.java

@@ -26,7 +26,10 @@ import net.ranides.assira.math.MathUtils;
  *
  * @author Ranides Atterwim <ranides@gmail.com>
  */
-@SuppressWarnings("PMD.TooManyPublicMethods")
+@SuppressWarnings({
+    "PMD.TooManyPublicMethods",
+    "PMD.TooManyDifferentMethods"
+})
 public final class StrBuilder implements CharSequence, Appendable, Serializable {
     
     private static final long serialVersionUID = 1L;

+ 0 - 1
assira/src/main/java/net/ranides/assira/text/StringIO.java

@@ -14,7 +14,6 @@ import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.io.Reader;
 import java.nio.charset.Charset;
-import java.nio.charset.CharsetEncoder;
 import java.util.ArrayList;
 import java.util.List;
 import net.ranides.assira.collection.arrays.ArrayAllocator;

+ 1 - 0
assira/src/main/java/net/ranides/assira/text/StringUtils.java

@@ -219,6 +219,7 @@ public final class StringUtils {
         return builder.toString();
     }
     
+    @SuppressWarnings("PMD.CyclomaticComplexity")
     private static void processEsc(CharStreamer<CharsType> stream) {
         if( stream.end() ) {
             throw new IllegalArgumentException("unclosed escape sequence");

+ 3 - 3
assira/src/main/java/net/ranides/assira/trace/TraceUtils.java

@@ -279,17 +279,17 @@ public final class TraceUtils {
 
         @Override
         public String calleeName() {
-            return ReflectFrame.get(new Exception(), FIRST).getClassName();
+            return ReflectFrame.get(new Exception(), FIRST).getClassName(); //NOPMD
         }
         
         @Override
         public String callerName() {
-            return ReflectFrame.get(new Exception(), FIRST+1).getClassName();
+            return ReflectFrame.get(new Exception(), FIRST+1).getClassName(); //NOPMD
         }
         
         @Override
         public List<String> names() {
-            return new FrameArray(new Exception().getStackTrace(), FIRST);
+            return new FrameArray(new Exception().getStackTrace(), FIRST); //NOPMD
         }
 
         @Override

+ 1 - 1
assira/src/test/java/net/ranides/assira/collection/arrays/NativeArrayTest.java

@@ -49,7 +49,7 @@ public class NativeArrayTest {
 	@Test
     public void testWrapErrors() {
 		NewAssert.assertThrows(IllegalArgumentException.class, ()->{
-			NativeArray.wrap(new Integer(17));
+			NativeArray.wrap(Integer.valueOf(17));
 		});
 	}
     

+ 3 - 0
assira/src/test/java/net/ranides/assira/io/IOUtilsTest.java

@@ -6,6 +6,8 @@
  */
 package net.ranides.assira.io;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import edu.umd.cs.findbugs.annotations.SuppressWarnings;
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.Closeable;
@@ -174,6 +176,7 @@ public class IOUtilsTest {
         });
     }
     
+    @SuppressFBWarnings("DMI_RANDOM_USED_ONLY_ONCE")
     private static byte[] random(int size, long seed) {
         byte[] ret = new byte[size];
         new Random(seed).nextBytes(ret);

+ 3 - 0
assira/src/test/java/net/ranides/assira/text/StrBuilderTest.java

@@ -6,6 +6,8 @@
  */
 package net.ranides.assira.text;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import edu.umd.cs.findbugs.annotations.SuppressWarnings;
 import java.io.IOException;
 import java.io.Reader;
 import java.io.Writer;
@@ -418,6 +420,7 @@ public class StrBuilderTest {
     }
     
     @Test
+    @SuppressFBWarnings("EC_UNRELATED_TYPES")
     public void testEquals() {
         StrBuilder a = new StrBuilder(16).append("Hello");
         StrBuilder b = new StrBuilder(160).append("He").append("llo");