PMD / warnings

assira/src/test/java/net/ranides/assira/collection/arrays/NativeArrayTest.java

@@ -12,10 +12,9 @@ import net.ranides.assira.collection.IntComparator;
 import net.ranides.assira.ContractTesters;
 import net.ranides.assira.generic.CompareUtils;
 import net.ranides.assira.generic.HashUtils;
-import net.ranides.assira.junit.NewAssert;
 import net.ranides.assira.test.TCollection;
 import org.junit.Test;
-import static org.junit.Assert.*;
+import static net.ranides.assira.junit.NewAssert.*;
 
 /**
  *
@@ -44,21 +43,21 @@ public class NativeArrayTest {
         run(index -> String.format("%02d", index) );
         
         ContractTesters.runner()
-            .ignore("NativeArrayTester.basicCompare")
-            .ignore("NativeArrayTester.basicCompare_cmp");
+            .ignore("NativeArrayTester.testCompare")
+            .ignore("NativeArrayTester.testCompare_cmp");
         run(index -> new Random(1027*index).nextBoolean());
     }
 	
 	@Test
     public void testAllocateErrors() {
-		NewAssert.assertThrows(UnsupportedOperationException.class, ()->{
+		assertThrows(UnsupportedOperationException.class, ()->{
 			NativeArray.allocate(Void.TYPE, 4);
 		});
 	}
 	
 	@Test
     public void testWrapErrors() {
-		NewAssert.assertThrows(IllegalArgumentException.class, ()->{
+		assertThrows(IllegalArgumentException.class, ()->{
 			NativeArray.wrap(Integer.valueOf(17));
 		});
 	}

assira/src/test/java/net/ranides/assira/collection/arrays/NativeArrayTester.java

@@ -23,13 +23,17 @@ import net.ranides.assira.junit.TestContract;
  *
  * @author Ranides Atterwim <ranides@gmail.com>
  */
+@SuppressWarnings({
+    "PMD.JUnit4TestShouldUseTestAnnotation",
+    "PMD.MethodNameRules"
+})
 public class NativeArrayTester<K> {
     
     @Resource(name = "collection!")
     private TCollection<K> $var;
    
     @TestContract
-    public void basicCompare(Function<int[], NativeArray> f) {
+    public void testCompare(Function<int[], NativeArray> f) {
         NativeArray a = f.apply(new int[]{1,3,5,7});
         NativeArray b = f.apply(new int[]{1,3,5,7});
         NativeArray c = f.apply(new int[]{1,3,5});
@@ -56,7 +60,7 @@ public class NativeArrayTester<K> {
     }
     
     @TestContract
-    public void basicCompare_cmp(Function<int[], NativeArray> f) {
+    public void testCompare_cmp(Function<int[], NativeArray> f) {
         Comparator cmp = CompareUtils.comparator().reversed();
             
         NativeArray a = f.apply(new int[]{1,3,5,7});
@@ -85,7 +89,7 @@ public class NativeArrayTester<K> {
     }
     
     @TestContract
-    public void basicEquals(Function<int[], NativeArray> f) {
+    public void testEquals(Function<int[], NativeArray> f) {
         NativeArray a = f.apply(new int[]{1,3,5,7});
         NativeArray b = f.apply(new int[]{1,3,5,7});
         NativeArray c = f.apply(new int[]{1,3,5});
@@ -98,7 +102,7 @@ public class NativeArrayTester<K> {
     }
 
     @TestContract
-    public void basicSet(Function<int[], NativeArray> f) {
+    public void testSet(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5,7});
         target.set(0, $var.item(4).value());
         target.set(1, $var.item(6).value());
@@ -121,7 +125,7 @@ public class NativeArrayTester<K> {
     }
     
     @TestContract
-    public void basicMove(Function<int[], NativeArray> f) {
+    public void testMove(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5,7});
         
         target.move(0,1);
@@ -143,7 +147,7 @@ public class NativeArrayTester<K> {
     }
     
     @TestContract
-    public void basicSwap(Function<int[], NativeArray> f) {
+    public void testSwap(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5,7,2,4});
         
         target.swap(0,1);
@@ -161,7 +165,7 @@ public class NativeArrayTester<K> {
     }
     
     @TestContract
-    public void basicLRCompare(Function<int[], NativeArray> f) {
+    public void testLRCompare(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5,7});
         
         NativeComparator lcmp = target.lcmp($var.item(4).value());
@@ -179,7 +183,7 @@ public class NativeArrayTester<K> {
     }
     
     @TestContract
-    public void basicLRCompare_cmp(Function<int[], NativeArray> f) {
+    public void testLRCompare_cmp(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5,7});
         
         NativeComparator lcmp = target.lcmp($var.item(4).value(), CompareUtils.comparator().reversed());
@@ -197,7 +201,7 @@ public class NativeArrayTester<K> {
     }
 	
 	@TestContract
-    public void basicEQCompare(Function<int[], NativeArray> f) {
+    public void testEQCompare(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5,7});
         
         IntPredicate cmp = target.cmp($var.item(4).value());
@@ -210,7 +214,7 @@ public class NativeArrayTester<K> {
     }
     
     @TestContract
-    public void basicComparator(Function<int[], NativeArray> f) {
+    public void testComparator(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5,7,2});
         IntComparator icmp = target.comparator();
         
@@ -233,7 +237,7 @@ public class NativeArrayTester<K> {
     }
     
     @TestContract
-    public void basicComparator_cmp(Function<int[], NativeArray> f) {
+    public void testComparator_cmp(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5,7,2});
         IntComparator icmp = target.comparator(CompareUtils.comparator().reversed());
         
@@ -256,14 +260,14 @@ public class NativeArrayTester<K> {
     }
     
     @TestContract
-    public void basicToString(Function<int[], NativeArray> f) {
+    public void testToString(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5,7,2});
         String exp = $var.list(1,3,5,7,2).into(new ArrayList<>()).toString();
         assertEquals(exp, target.toString());
     }
     
     @TestContract
-    public void basicAllocate(Function<int[], NativeArray> f) {
+    public void testAllocate(Function<int[], NativeArray> f) {
         NativeArray target = f.apply(new int[]{1,3,5});
         NativeArray z = target.allocate(0);
         assertEquals(0, z.size());

assira/src/test/java/net/ranides/assira/collection/rmq/IntRMQTableTest.java

@@ -72,7 +72,7 @@ public class IntRMQTableTest {
             .ignore("IntCollectionTester.basicRemove")
             .ignore("IntCollectionTester.basicRetainAll")
 
-            .ignore("RMQTester.appendFind")
+            .ignore("RMQTester.testFindAppend")
 
             .function(new int[0], $make)
 			.run()

assira/src/test/java/net/ranides/assira/collection/rmq/RMQTableTest.java

@@ -54,7 +54,7 @@ public class RMQTableTest {
             .ignore("CollectionTester.basicRemove") 
             .ignore("CollectionTester.basicRetainAll") 
                 
-            .ignore("RMQTester.appendFind")
+            .ignore("RMQTester.testFindAppend")
             .function(new int[0], $make)
 			.run()
         );

assira/src/test/java/net/ranides/assira/collection/rmq/RMQTester.java

@@ -17,6 +17,10 @@ import net.ranides.assira.junit.TestContract;
  *
  * @author Ranides Atterwim <ranides@gmail.com>
  */
+@SuppressWarnings({
+    "PMD.JUnit4TestShouldUseTestAnnotation",
+    "PMD.MethodNameRules"
+})
 public class RMQTester<K> {
     
     @Resource(name = "collection!")
@@ -46,7 +50,7 @@ public class RMQTester<K> {
     private static final int[] V2 = new int[]{9,8,7,6,5,4,3,2,1,0};
     
     @TestContract
-    public void basicFind(Function<int[], RMQList<K>> f) {
+    public void testFind(Function<int[], RMQList<K>> f) {
         RMQList list1 = f.apply(V1);
         
         assertEquals($var.item(9).value(), list1.find());
@@ -68,7 +72,7 @@ public class RMQTester<K> {
     }
     
     @TestContract
-    public void boundsFind(Function<int[], RMQList<K>> f) {
+    public void testFindBounds(Function<int[], RMQList<K>> f) {
         RMQList target = f.apply(V1);
         
         assertThrows(IndexOutOfBoundsException.class, ()->{
@@ -104,7 +108,7 @@ public class RMQTester<K> {
     }
     
     @TestContract
-    public void appendFind(RMQList<K> target) {
+    public void testFindAppend(RMQList<K> target) {
         target.add($var.item(1).value());
         assertEquals($var.item(1).value(), target.find());
         
@@ -117,7 +121,7 @@ public class RMQTester<K> {
     }
     
     @TestContract
-    public void basicIterator(Function<int[], RMQList<K>> f) {
+    public void testIterator(Function<int[], RMQList<K>> f) {
         RMQList<K> target = f.apply(V1);
         
         IteratorTester.basicIterator(target.iterator(), 0, $var.list(V1).values());

assira/src/test/java/net/ranides/assira/collection/suite/lists/IntListTester.java

@@ -6,8 +6,6 @@
  */
 package net.ranides.assira.collection.suite.lists;
 
-import java.util.ArrayList;
-import java.util.List;
 import java.util.NoSuchElementException;
 import java.util.function.Function;
 import javax.annotation.Resource;
@@ -23,6 +21,7 @@ import net.ranides.assira.junit.TestContract;
  *
  * @author Ranides Atterwim <ranides@gmail.com>
  */
+@SuppressWarnings("PMD.MethodNameRules")
 public class IntListTester {
     
     private static final int[] VA1 = new int[]{1,3,5,7,9};

assira/src/test/java/net/ranides/assira/collection/suite/lists/ListTester.java

@@ -23,6 +23,7 @@ import net.ranides.assira.junit.TestContract;
  *
  * @author Ranides Atterwim <ranides@gmail.com>
  */
+@SuppressWarnings("PMD.MethodNameRules")
 public class ListTester<T> {
     
     @Resource(name = "collection!")

assira/src/test/java/net/ranides/assira/collection/suite/lookups/LookupTester.java

@@ -26,6 +26,7 @@ import net.ranides.assira.junit.TestContract;
  *
  * @author Ranides Atterwim <ranides@gmail.com>
  */
+@SuppressWarnings("PMD.MethodNameRules")
 public final class LookupTester<K> {
     
     @Resource(name = "map!")

assira/src/test/java/net/ranides/assira/collection/suite/lookups/SortedLookupTester.java

@@ -25,6 +25,7 @@ import net.ranides.assira.junit.TestContract;
  *
  * @author Ranides Atterwim <ranides@gmail.com>
  */
+@SuppressWarnings("PMD.MethodNameRules")
 public final class SortedLookupTester<K> {
     
     @Resource(name = "map!")

assira/src/test/java/net/ranides/assira/collection/suite/maps/ASortedMapTester.java

@@ -20,6 +20,7 @@ import net.ranides.assira.junit.TestContract;
  *
  * @author Ranides Atterwim <ranides@gmail.com>
  */
+@SuppressWarnings("PMD.MethodNameRules")
 public final class ASortedMapTester<K,V> {
     
     @Resource(name = "map!")