findbugs

src/main/java/net/ranides/assira/collection/list/EmptyListIterator.java

@@ -16,6 +16,13 @@ import java.util.NoSuchElementException;
  * @author ranides
  */
 public final class EmptyListIterator<T> implements ListIterator<T> {
+    
+    public static final ListIterator INSTANCE = new EmptyListIterator();
+    
+    @SuppressWarnings("unchecked")
+    public static <TT> ListIterator<TT> emptyIterator() {
+        return INSTANCE;
+    }
 
     @Override
     public boolean hasNext() {

src/main/java/net/ranides/assira/math/LFSR.java

@@ -15,6 +15,8 @@ import java.util.Random;
  */
 public final class LFSR extends Random {
 
+    private static final long serialVersionUID = 2L;
+    
     private static final int M = 32;
     // hard-coded for 32-bits
     private static final int[] TAPS = {1, 2, 22, 32};

src/main/java/net/ranides/assira/text/StringUtils.java

@@ -143,7 +143,8 @@ public final class StringUtils {
 
     public static <T extends CharSequence> String join(Iterable<T> values, String separator) {
         if (values instanceof Collection) {
-            return join( ((Collection<?>)values).toArray(new CharSequence[0]), separator );
+            Collection<?> collection = (Collection<?>)values;
+            return join( collection.toArray(new CharSequence[collection.size()]), separator );
         }
         StringBuilder builder = new StringBuilder();
         boolean first = true;
@@ -157,7 +158,8 @@ public final class StringUtils {
 
     public static <T extends CharSequence> String join(Iterable<T> values) {
         if (values instanceof Collection) {
-            return join( ((Collection<?>)values).toArray(new CharSequence[0]) );
+            Collection<?> collection = (Collection<?>)values;
+            return join( collection.toArray(new CharSequence[collection.size()]));
         }
         StringBuilder builder = new StringBuilder();
         for(Object value : values) {

src/main/java/net/ranides/assira/text/format/AnsiSelector.java

@@ -66,7 +66,7 @@ public abstract class AnsiSelector implements Serializable {
 /* ************************************************************************** */
     
     
-    public static final class Regex extends AnsiSelector implements Serializable {
+    public static final class Regex extends AnsiSelector {
 
         private static final long serialVersionUID = 0x101L;
 
@@ -115,7 +115,7 @@ public abstract class AnsiSelector implements Serializable {
 
     }
     
-    public static final class Substr extends AnsiSelector implements Serializable {
+    public static final class Substr extends AnsiSelector {
 
         private static final long serialVersionUID = 0x101L;
         private String text;

src/main/java/net/ranides/assira/text/format/AnsiStringBuilder.java

@@ -12,6 +12,8 @@ package net.ranides.assira.text.format;
  */
 public class AnsiStringBuilder extends AnsiString {
     
+    private static final long serialVersionUID = 3L;
+    
     private int position;
     
     public AnsiStringBuilder() {