pmd

src/main/java/net/ranides/assira/collection/ByteArrays.java

@@ -10,7 +10,11 @@ package net.ranides.assira.collection;
  *
  * @author ranides
  */
-public class ByteArrays {
+public final class ByteArrays {
+    
+    private ByteArrays() {
+        // utility class
+    }
     
     public static byte[] make(int size, byte value) {
         byte[] content = new byte[size];

src/main/java/net/ranides/assira/text/AbstractStrBuilder.java

@@ -130,7 +130,7 @@ public class AbstractStrBuilder<Self extends AbstractStrBuilder<Self>> implement
      *
      * @param str  the string to copy, null treated as blank string
      */
-    @SuppressWarnings("OverridableMethodCallInConstructor")
+    @SuppressWarnings({"OverridableMethodCallInConstructor", "PMD"})
     public AbstractStrBuilder(String str) {
         super();
         if (str == null) {

src/main/java/net/ranides/assira/trace/LoggerUtils.java

@@ -34,28 +34,30 @@ public final class LoggerUtils {
 
     public static final String INVOKE_ERROR = "invoke error";
 
-    public static void resetJavaLogger(java.util.logging.Level level) {
+    public static java.util.logging.Logger resetJavaLogger(java.util.logging.Level level) {
         java.util.logging.LogManager.getLogManager().reset();
         java.util.logging.Logger global = java.util.logging.Logger.getLogger(java.util.logging.Logger.GLOBAL_LOGGER_NAME);
         global.setLevel(level);
+        return global;
 }
 
-    public static void resetJavaLogger(boolean enable) {
-        resetJavaLogger(enable ? java.util.logging.Level.ALL : java.util.logging.Level.OFF );
+    public static java.util.logging.Logger resetJavaLogger(boolean enable) {
+        return resetJavaLogger(enable ? java.util.logging.Level.ALL : java.util.logging.Level.OFF );
     }
     
-    public static void resetLogger4j(boolean enable) {
-        resetLogger4j(enable ? org.apache.log4j.Level.ALL : org.apache.log4j.Level.OFF);
+    public static org.apache.log4j.Logger resetLogger4j(boolean enable) {
+        return resetLogger4j(enable ? org.apache.log4j.Level.ALL : org.apache.log4j.Level.OFF);
     }
     
-    public static void resetLogger4j(org.apache.log4j.Level level) {
-        resetLogger4j(level, APPENDER);
+    public static org.apache.log4j.Logger resetLogger4j(org.apache.log4j.Level level) {
+        return resetLogger4j(level, APPENDER);
     }
 
-    public static void resetLogger4j(org.apache.log4j.Level level, org.apache.log4j.Appender appender) {
+    public static org.apache.log4j.Logger resetLogger4j(org.apache.log4j.Level level, org.apache.log4j.Appender appender) {
         org.apache.log4j.Logger logger = org.apache.log4j.Logger.getRootLogger();
         logger.addAppender(appender);
         logger.setLevel(level);
+        return logger;
     }
 
     public static AdvLogger getLogger() {

src/main/java/net/ranides/assira/xml/NodeCollection.java

@@ -78,6 +78,7 @@ public abstract class NodeCollection implements List<Node> {
         private final Set<String> keys;
         private final Set<Entry<String,Node>> entries;
 
+        @SuppressWarnings("PMD")
         private LMap(NamedNodeMap source) {
             this.map = source;
             this.nodeList = new VirtualList<Node>() {

src/test/java/net/ranides/assira/math/LFSRTest.java

@@ -99,7 +99,7 @@ public class LFSRTest {
             }
         }
         
-        System.out.printf("cycle length for seed %d > %d.\n", seed, MAX_CYCLE);
+        LoggerUtils.dump("cycle length for seed %d > %d.\n", seed, MAX_CYCLE);
         return MAX_CYCLE;
     }