#40 Fix AClass#asString and RContext#resolve

بسته‌شده
4 سال پیش باز شده توسط ranides · 1 دیدگاه

At this moment we have a problem: RContext#resolve can go into stackoverflow:

    at net.ranides.assira.reflection.impl.RContext.resolve0(RContext.java:74)
    at net.ranides.assira.reflection.impl.RContext.resolve(RContext.java:62)
    at net.ranides.assira.reflection.impl.RContext.resolve0(RContext.java:74)
    at net.ranides.assira.reflection.impl.RContext.resolve(RContext.java:62)
    at net.ranides.assira.reflection.impl.RContext.resolve0(RContext.java:74)
    at net.ranides.assira.reflection.impl.RContext.resolve(RContext.java:62)
    at net.ranides.assira.reflection.impl.RContext.resolve0(RContext.java:74)
At this moment we have a problem: RContext#resolve can go into stackoverflow: ``` at net.ranides.assira.reflection.impl.RContext.resolve0(RContext.java:74) at net.ranides.assira.reflection.impl.RContext.resolve(RContext.java:62) at net.ranides.assira.reflection.impl.RContext.resolve0(RContext.java:74) at net.ranides.assira.reflection.impl.RContext.resolve(RContext.java:62) at net.ranides.assira.reflection.impl.RContext.resolve0(RContext.java:74) at net.ranides.assira.reflection.impl.RContext.resolve(RContext.java:62) at net.ranides.assira.reflection.impl.RContext.resolve0(RContext.java:74) ```
ranides نظر 4 سال پیش
مالک

It is hard to say, what is cause of the problem, but it can be reproduced in AClassTest#testRecursiveString

At this moment we inserted workaround inside AClass#toString, but it causes that nested types can't be converted to correct string.

If we declare parameterized type Something<T> and then declare nested type Something<Something<Something<T>>>, we have infinite recursion.

Somewhere under the hood, toString converts parameters to strings. To do so, it has to create parameters list first. Parameter list is created lazily, and every parameter creates result using context:typeinfo.

typeinfo calls resolveTV

IContext somewhere

It is hard to say, what is cause of the problem, but it can be reproduced in AClassTest#testRecursiveString At this moment we inserted workaround inside AClass#toString, but it causes that nested types can't be converted to correct string. If we declare parameterized type `Something<T>` and then declare nested type `Something<Something<Something<T>>>`, we have infinite recursion. Somewhere under the hood, toString converts parameters to strings. To do so, it has to create parameters list first. Parameter list is created lazily, and every parameter creates result using `context:typeinfo`. typeinfo calls resolveTV IContext somewhere
ranides 4 سال پیش بسته شد
ranides ارجاع این مسئله به کامیت 4 سال پیش
برای پیوستن به گفتگو، وارد شودید.
بدون نقطه عطف
بدون مسئول رسیدگی
1 مشارکت کننده
درحال بارگذاری...
لغو
ذخيره
هنوز محتوایی ایجاد نشده.