#89 ZipReader#read(byte[]...)

Затворени
отворен преди 4 години от ranides · 2 коментара
ranides коментира преди 4 години

Probably we will miscalculate number of bytes if signature is partially read

Anyway, we read data byte-by-byte, which is not effective.

We should skip prefix (if necessary), put signature (unread part), then invoke ordinary bulk read with modified offset and limit.

Probably we will miscalculate number of bytes if signature is partially read Anyway, we read data byte-by-byte, which is not effective. We should skip prefix (if necessary), put signature (unread part), then invoke ordinary bulk read with modified offset and limit.
ranides коментира преди 3 години
Притежател

We skip prefix before signature using buffered read. We calculate correctly number of bytes.

We skip prefix before signature using buffered read. We calculate correctly number of bytes.
ranides посочи тази задача от ревизия преди 3 години
ranides коментира преди 3 години
Притежател

Tests are done "naturally", our PackageScanner uses ZipReader internally. PackageScanner is tested both explicitly and implicitly (by ContractTesters).

Tests are done "naturally", our PackageScanner uses ZipReader internally. PackageScanner is tested both explicitly and implicitly (by ContractTesters).
Впишете се за да се присъедините към разговора.
Няма етап
Няма изпълнител
1 участника
Зареждане...
Отказ
Запис
Все още няма съдържание.