#89 ZipReader#read(byte[]...)

Stängd
öppnade 4 år sedan av ranides · 2 kommentarer
ranides kommenterad 4 år sedan

Probably we will miscalculate number of bytes if signature is partially read

Anyway, we read data byte-by-byte, which is not effective.

We should skip prefix (if necessary), put signature (unread part), then invoke ordinary bulk read with modified offset and limit.

Probably we will miscalculate number of bytes if signature is partially read Anyway, we read data byte-by-byte, which is not effective. We should skip prefix (if necessary), put signature (unread part), then invoke ordinary bulk read with modified offset and limit.
ranides kommenterad 3 år sedan
Ägare

We skip prefix before signature using buffered read. We calculate correctly number of bytes.

We skip prefix before signature using buffered read. We calculate correctly number of bytes.
ranides refererade till detta ärende från en incheckning 3 år sedan
ranides kommenterad 3 år sedan
Ägare

Tests are done "naturally", our PackageScanner uses ZipReader internally. PackageScanner is tested both explicitly and implicitly (by ContractTesters).

Tests are done "naturally", our PackageScanner uses ZipReader internally. PackageScanner is tested both explicitly and implicitly (by ContractTesters).
Logga in för att delta i denna konversation.
Ingen Milsten
Ingen förvärvare
1 Deltagare
Laddar...
Avbryt
Spara
Det finns inget innehåll än.