#89 ZipReader#read(byte[]...)

Fechado
4 anos atrás foi aberto por ranides · 2 comentários

Probably we will miscalculate number of bytes if signature is partially read

Anyway, we read data byte-by-byte, which is not effective.

We should skip prefix (if necessary), put signature (unread part), then invoke ordinary bulk read with modified offset and limit.

Probably we will miscalculate number of bytes if signature is partially read Anyway, we read data byte-by-byte, which is not effective. We should skip prefix (if necessary), put signature (unread part), then invoke ordinary bulk read with modified offset and limit.
ranides comentado 3 anos atrás
Proprietário

We skip prefix before signature using buffered read. We calculate correctly number of bytes.

We skip prefix before signature using buffered read. We calculate correctly number of bytes.
ranides citou este problema em um commit 3 anos atrás
ranides comentado 3 anos atrás
Proprietário

Tests are done "naturally", our PackageScanner uses ZipReader internally. PackageScanner is tested both explicitly and implicitly (by ContractTesters).

Tests are done "naturally", our PackageScanner uses ZipReader internally. PackageScanner is tested both explicitly and implicitly (by ContractTesters).
Faça login para participar desta conversação.
Sem milestone
Não atribuída
1 participantes
Carregando...
Cancelar
Salvar
Ainda não há conteúdo.