#89 ZipReader#read(byte[]...)

Закрыто
4 лет назад открыта ranides · комментариев: 2
ranides прокомментировал 4 лет назад

Probably we will miscalculate number of bytes if signature is partially read

Anyway, we read data byte-by-byte, which is not effective.

We should skip prefix (if necessary), put signature (unread part), then invoke ordinary bulk read with modified offset and limit.

Probably we will miscalculate number of bytes if signature is partially read Anyway, we read data byte-by-byte, which is not effective. We should skip prefix (if necessary), put signature (unread part), then invoke ordinary bulk read with modified offset and limit.
ranides прокомментировал 3 лет назад
Владелец

We skip prefix before signature using buffered read. We calculate correctly number of bytes.

We skip prefix before signature using buffered read. We calculate correctly number of bytes.
ranides упомянул эту задачу в коммите 3 лет назад
ranides прокомментировал 3 лет назад
Владелец

Tests are done "naturally", our PackageScanner uses ZipReader internally. PackageScanner is tested both explicitly and implicitly (by ContractTesters).

Tests are done "naturally", our PackageScanner uses ZipReader internally. PackageScanner is tested both explicitly and implicitly (by ContractTesters).
Войдите, чтобы присоединиться к обсуждению.
Нет этапа
Нет ответственного
1 участников
Загрузка...
Отмена
Сохранить
Пока нет содержимого.