#85 Review: EventDispatcher#dispatchEvent

Затворени
отворен преди 4 години от ranides · 1 коментара
ranides коментира преди 4 години

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods.

I am afraid, we don't override all paths in proactor and reactor.

In effect: some calls are scheduled, some called directly, and there is a big mess.

Public methods should be final.

Protected methods should have better names and overloads.

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods. I am afraid, we don't override all paths in proactor and reactor. In effect: some calls are scheduled, some called directly, and there is a big mess. Public methods should be final. Protected methods should have better names and overloads.
ranides посочи тази задача от ревизия преди 3 години
ranides коментира преди 3 години
Притежател

We changed hierarchy!

EventRouter is abstract class and offers basic support for "listeners" field.

Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.

We changed hierarchy! EventRouter is abstract class and offers basic support for "listeners" field. Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.
Впишете се за да се присъедините към разговора.
Няма етап
Няма изпълнител
1 участника
Зареждане...
Отказ
Запис
Все още няма съдържание.