#85 Review: EventDispatcher#dispatchEvent

Chiuso
aperto 4 anni fa da ranides · 1 commenti
ranides ha commentato 4 anni fa

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods.

I am afraid, we don't override all paths in proactor and reactor.

In effect: some calls are scheduled, some called directly, and there is a big mess.

Public methods should be final.

Protected methods should have better names and overloads.

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods. I am afraid, we don't override all paths in proactor and reactor. In effect: some calls are scheduled, some called directly, and there is a big mess. Public methods should be final. Protected methods should have better names and overloads.
ranides referenced this issue from a commit 3 anni fa
ranides ha commentato 3 anni fa
Proprietario

We changed hierarchy!

EventRouter is abstract class and offers basic support for "listeners" field.

Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.

We changed hierarchy! EventRouter is abstract class and offers basic support for "listeners" field. Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.
Sign in to join this conversation.
Nessuna milestone
Nessun assegnatario
1 Partecipanti
Caricamento...
Annulla
Salva
Non ci sono ancora contenuti.