#85 Review: EventDispatcher#dispatchEvent

Uzavrená
otvorené 4 rokov pred užívateľom ranides · 1 komentárov
ranides okomentoval 4 rokov pred

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods.

I am afraid, we don't override all paths in proactor and reactor.

In effect: some calls are scheduled, some called directly, and there is a big mess.

Public methods should be final.

Protected methods should have better names and overloads.

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods. I am afraid, we don't override all paths in proactor and reactor. In effect: some calls are scheduled, some called directly, and there is a big mess. Public methods should be final. Protected methods should have better names and overloads.
ranides sa odvolal na túto issue z commitu 3 rokov pred
ranides okomentoval 3 rokov pred
Vlastník

We changed hierarchy!

EventRouter is abstract class and offers basic support for "listeners" field.

Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.

We changed hierarchy! EventRouter is abstract class and offers basic support for "listeners" field. Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.
Prihláste sa pre zapojenie do konverzácie.
Žiadny míľnik
Žiadny priradený
1 účastníkov
Načítavanie...
Zrušiť
Uložiť
Zatiaľ neexistuje žiadny obsah.