#85 Review: EventDispatcher#dispatchEvent

已關閉
ranides4 年之前創建 · 1 條評論

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods.

I am afraid, we don't override all paths in proactor and reactor.

In effect: some calls are scheduled, some called directly, and there is a big mess.

Public methods should be final.

Protected methods should have better names and overloads.

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods. I am afraid, we don't override all paths in proactor and reactor. In effect: some calls are scheduled, some called directly, and there is a big mess. Public methods should be final. Protected methods should have better names and overloads.
ranides3 年之前 關閉
ranides 在代碼提交 3 年之前 中引用了該問題
ranides 評論 3 年之前'
所有者

We changed hierarchy!

EventRouter is abstract class and offers basic support for "listeners" field.

Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.

We changed hierarchy! EventRouter is abstract class and offers basic support for "listeners" field. Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.
登入 才能加入這對話。
未選擇里程碑
未指派成員
1 參與者
正在加載...
取消
保存
尚未有任何內容