#85 Review: EventDispatcher#dispatchEvent

Fechado
há 4 anos atrás aberto por ranides · 1 comentários

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods.

I am afraid, we don't override all paths in proactor and reactor.

In effect: some calls are scheduled, some called directly, and there is a big mess.

Public methods should be final.

Protected methods should have better names and overloads.

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods. I am afraid, we don't override all paths in proactor and reactor. In effect: some calls are scheduled, some called directly, and there is a big mess. Public methods should be final. Protected methods should have better names and overloads.
ranides referenciou este problema num commit há 3 anos atrás
ranides comentado há 3 anos atrás
Proprietário

We changed hierarchy!

EventRouter is abstract class and offers basic support for "listeners" field.

Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.

We changed hierarchy! EventRouter is abstract class and offers basic support for "listeners" field. Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.
Faça login para participar desta conversação.
Sem Objetivo
Sem utilizador atribuido
1 Participantes
A carregar...
Cancelar
Guardar
Ainda não existe conteúdo.