#85 Review: EventDispatcher#dispatchEvent

Cerrada
aberta %!s(int64=4) %!d(string=hai) anos por ranides · 1 comentarios

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods.

I am afraid, we don't override all paths in proactor and reactor.

In effect: some calls are scheduled, some called directly, and there is a big mess.

Public methods should be final.

Protected methods should have better names and overloads.

signalEvent and handleEvent are public methods heavily using protected dispatchEvent methods. I am afraid, we don't override all paths in proactor and reactor. In effect: some calls are scheduled, some called directly, and there is a big mess. Public methods should be final. Protected methods should have better names and overloads.
ranides mencionada esta incidencia nunha achega %!s(int64=3) %!d(string=hai) anos

We changed hierarchy!

EventRouter is abstract class and offers basic support for "listeners" field.

Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.

We changed hierarchy! EventRouter is abstract class and offers basic support for "listeners" field. Every implementation (dispatcher, proactor, reactor) is independent. We do not mix anything with dispatcher at all.
Accede para unirte á conversa.
Sen fito
Sen asignado
1 participantes
Cargando...
Cancelar
Gardar
Aínda non existe contido.